Image component and magnified image#162
Open
gfrn wants to merge 12 commits into
Open
Conversation
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Why does the zoom go outside the image when clicking on the right but inside when clicking on the left?
Collaborator
Author
There was a 100px window where the padding didn't kick in, and it resulted in that, but I removed it because it's just better to use the native breakpoints anyway, so that should be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two components we made for Evo, one that provides an "upgraded" HTML![]()
tag that displays a placeholder if the image fails to load, and displays a loading indicator while the image loads.
It also adds another component (mainly used for diffraction images and particle picking) that allows users to zoom in on any area in an image, with lens/zoom sizes being configurable. It also allows users to set contrast, brightness and invert colours to make features easier to detect
It is also built entirely with CSS, MUI and HTML, so it requires no extra dependencies.
This depends on #161, as it would be ideal for us to only import components we're using to minimise bundle size and dependencies